Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic plugin details page #2351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Oct 3, 2023

New plugin details page as specified in the figma created by the content designer of the team prior to going into maintenance mode: https://www.figma.com/file/sWnqT4u4uup91TuTe9T3tp/GOV.UK-Prototype-Kit?type=design&node-id=321-2&mode=design&t=DrJrxm6jc6zYT7EL-0

Implementation:

  • Create Plugins details page
  • Move the install, update and uninstall buttons to the new details page
  • Change each plugin header in the plugins page to links to the new details page
  • Include a link to toggle details from installed to latest plugin details if they are different
  • Add unit test for the plugin details route
  • Change acceptance tests to use the new plugins details page

@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 7 times, most recently from 875c4ae to 75b727c Compare October 4, 2023 21:25
@BenSurgisonGDS BenSurgisonGDS changed the base branch from main to Simplify-and-improve-acceptance-tests October 9, 2023 10:50
@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 3 times, most recently from a5a58f0 to 7620fef Compare October 9, 2023 13:44
@BenSurgisonGDS BenSurgisonGDS self-assigned this Oct 9, 2023
@BenSurgisonGDS BenSurgisonGDS marked this pull request as ready for review October 9, 2023 14:23
@BenSurgisonGDS BenSurgisonGDS force-pushed the Simplify-and-improve-acceptance-tests branch 2 times, most recently from 5823d3f to be59b35 Compare October 11, 2023 10:27
Base automatically changed from Simplify-and-improve-acceptance-tests to main October 11, 2023 10:49
@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 5 times, most recently from c0f7bca to 35d4057 Compare October 16, 2023 15:42
@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 3 times, most recently from e09427a to e987e6a Compare October 27, 2023 10:16
@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 2 times, most recently from de17143 to 6f3eb78 Compare November 10, 2023 10:16
@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 2 times, most recently from 5e8eaa9 to 89bce81 Compare November 20, 2023 12:57
@BenSurgisonGDS BenSurgisonGDS force-pushed the basic-plugin-details-page branch 2 times, most recently from 2fdf913 to 1209216 Compare November 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant