Increase the size of histogram buckets #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have more histogram buckets at longer time spans (e.g. 1 min to 5 mins, 5 mins to 10 mins, 10 mins to 30 mins, 30 mins to 1 hour) and less at shorter time spans. For publishing latency, we basically don't care how fast it is if it's less than 1 second, but 1 hour is a lot worse than 1 minute. Currently the buckets just group everything longer than 10s as "somewhere between 10 seconds and infinity".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have more histogram buckets at longer time spans (e.g. 1 min to 5 mins, 5 mins to 10 mins, 10 mins to 30 mins, 30 mins to 1 hour) and less at shorter time spans. For publishing latency, we basically don't care how fast it is if it's less than 1 second, but 1 hour is a lot worse than 1 minute. Currently the buckets just group everything longer than 10s as "somewhere between 10 seconds and infinity".
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.