add migration 0487_job_st_fin_allrows_backpop
#4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this updates all "finished" jobs more than 24h since scheduled_for to the new "finished all notifications created" status. why 24h? 24h is how far back the check-for-missing-rows-in-completed-jobs celery task will look and so anything older than that won't get converted to "finished all notifications created" automatically. there *shouldn't* be any jobs that make it to 24h without all rows or being moved to a failed state by then anyway...
|
Is the squawk failure a matter of it being confused by the |
|
There’s already a 487 now so you’ll need to update the version number in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #4323
This updates all
finishedjobs more than 24h sincescheduled_forto the newfinished all notifications createdstatus. why 24h? 24h is how far back thecheck-for-missing-rows-in-completed-jobscelery task will look and so anything older than that won't get converted tofinished all notifications createdautomatically.There shouldn't be any jobs that make it to 24h without all rows or being moved to a failed state by then anyway...