Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make targets to generate manifests locally #3327

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

corlettb
Copy link
Contributor

@corlettb corlettb commented Jul 25, 2023

https://www.pivotaltracker.com/n/projects/1275640/stories/185391018

What

Add the ability to generate the manifest files locally.

Make targets:

-- Generate manifests against a fake environment
make cf_manifest_stub
make app_autoscaler_manifest_stub
make prometheus_manifest_stub

-- Generate environment manifests
gds aws paas-<aws env>-admin -- make <env> cf_manifest
gds aws paas-<aws env>-admin -- make <env> app_autoscaler_manifest

-- Prometheus requires credhub credentials
gds aws paas-<aws env>-admin -- make <env> credhub
credhub login --sso
make <env> prometheus_manifest

Why

When doing upstream updates it can be very awkward to test manifest tweaks. These new make targets allow SREs to quickly iterate on manifest tweaks.

How to review

Try the new make targets to generate manifest files.
Look at the changes.

Future

Tickets will be created for the following:

  • Adjust the existing pipeline to use these make targets to remove code duplication
  • Rescope the secrets the prometheus manifest generation requires so the generation no longer needs access to credhub.

🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

@corlettb corlettb changed the title Add make targets to generate example stub manifests locally Add make targets to generate manifests locally Jul 26, 2023
@corlettb corlettb force-pushed the 185391018-local-bosh-manifests branch from 209f70f to 9db0d43 Compare July 26, 2023 11:54
@corlettb corlettb force-pushed the 185391018-local-bosh-manifests branch from 9db0d43 to 470cd79 Compare July 26, 2023 12:06
@corlettb corlettb marked this pull request as ready for review July 26, 2023 12:32
Copy link
Contributor

@jackjoy-gds jackjoy-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corlettb corlettb closed this Jul 28, 2023
@corlettb corlettb merged commit b9c6d7f into main Jul 28, 2023
8 checks passed
@corlettb corlettb deleted the 185391018-local-bosh-manifests branch July 28, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants