added script to apply security group bindings for vpc peers #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjoy-gds
force-pushed
the
185442282_bind-security-groups-for-vpc-peers
branch
8 times, most recently
from
4447052
to
5ca736f
Compare
jackjoy-gds
force-pushed
the
185442282_bind-security-groups-for-vpc-peers
branch
11 times, most recently
from
bd2ee4d
to
8392d75
Compare
corlettb
reviewed
Sep 7, 2023
concourse/scripts/apply_security_group_bindings_from_vpc_peering_json.rb
Outdated
Show resolved
Hide resolved
concourse/scripts/apply_security_group_bindings_from_vpc_peering_json.rb
Show resolved
Hide resolved
jackjoy-gds
force-pushed
the
185442282_bind-security-groups-for-vpc-peers
branch
from
8392d75
to
1910d6f
Compare
corlettb
reviewed
Sep 8, 2023
concourse/scripts/apply_security_group_bindings_from_vpc_peering_json.rb
Show resolved
Hide resolved
corlettb
reviewed
Sep 8, 2023
concourse/scripts/apply_security_group_bindings_from_vpc_peering_json.rb
Outdated
Show resolved
Hide resolved
corlettb
reviewed
Sep 8, 2023
concourse/scripts/apply_security_group_bindings_from_vpc_peering_json.rb
Outdated
Show resolved
Hide resolved
jackjoy-gds
force-pushed
the
185442282_bind-security-groups-for-vpc-peers
branch
2 times, most recently
from
cf37502
to
031deff
Compare
corlettb
reviewed
Sep 8, 2023
concourse/scripts/apply_security_group_bindings_from_vpc_peering_json.rb
Outdated
Show resolved
Hide resolved
jackjoy-gds
force-pushed
the
185442282_bind-security-groups-for-vpc-peers
branch
from
031deff
to
f00b108
Compare
corlettb
approved these changes
Sep 11, 2023
jackjoy-gds
deleted the
185442282_bind-security-groups-for-vpc-peers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added a ruby script to apply security group bindings for vpc peers in the pipeline, as configured by extending the config of the existing env specific terraform vpc_peering json files.
I have left an example file in the repo for reference:
terraform/env.vpc_peering.json.exampleHow to review
Look at the code
Create a copy of this branch
Manually create VPC(s)
Create an env specific vpc_peering.json file using the format from the example and push to your branch
Configure the chosen dev env pipeline with your branch
Run the pipeline
Ensure that the correct security-group bindings are applied
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨