Add TLS listener and config for s3 broker #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjoy-gds
changed the title
jackjoy-gds
changed the title
add cert config to s3 broker s3 broker listen with TLS point s3 broker lb at 443 Using new s3-broker add bosh-signed TLS CA variables, and config to the manifest updated s3 broker release version added TLS listener in terraform
jackjoy-gds
force-pushed
the
rds-broker-listen-tls-take2
branch
from
d769c33
to
f2b275b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add bosh-signed TLS CA variables, and config to the manifest
updated s3 broker release version
added TLS listener in terraform
How to review
look at the code
deploy branch to a dev env and test s3 broker functionality
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨