[#185529919] Reworked instance tags in ruby script #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcgds
force-pushed
the
185529919-tag-name-rework
branch
from
05c21e8
to
a62dcc7
Compare
risicle
reviewed
Oct 2, 2023
risicle
reviewed
Oct 2, 2023
| if instance.engine == "postgres" && instance.engine_version.start_with?("10.") | ||
| MyLogger.instance.log_warn("instance #{instance.db_instance_identifier} is postgres 10 and will not be processed.") | ||
| next | ||
| end |
There was a problem hiding this comment.
Yes, it also surprised Andy
risicle
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I re-worked the rds instance tags in the script because not all rds instances use the deploy_env tag.
When testing in prod (using --dry-run and paas-prod-ro mode) I found that the script baulked with an exception if calling describe_orderable_db_instance_options with engine = postgres and engine_version = 10.23. I changed the script so that if it does find an existing postgres rds with an engine version of "10.xx" it will report it, will not attempt to upgrade it and will move on.
How to review
1 - review the code.
2 - In --dry-run mode the script should not try to modify anything but when running in a new environment I would also give yourself read-only access.
3 - Try it out in a dev env.
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨