PP-12687: Add dependency review workflow #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiming for consistency with app repos
katstevens
changed the title
marcotranchino
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to run the dependency-review shared workflow on pull requests in this repository, to replace the Snyk PR checks.
The main app repositories have a dedicated
pr.ymlworkflow file, with a shared_run-tests.ymlworkflow called pre- and post-merge. I've since added this to the product page repository as well.In an attempt to get the repository workflows in a consistent state, I've:
pr.ymlworkflowrun-testsjob totestsdependency-reviewaction in thepr.ymlworkflow