Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11314 add publishing workflow for release commits #6

Merged
merged 4 commits into from
Aug 23, 2023
Merged

PP-11314 add publishing workflow for release commits #6

merged 4 commits into from
Aug 23, 2023

Conversation

nlsteers
Copy link
Collaborator

WHAT

Simple action to publish the package when the version has been released by Concourse

@nlsteers nlsteers marked this pull request as draft August 15, 2023 17:07
@nlsteers nlsteers force-pushed the pp-11314/metrics_release_process branch 6 times, most recently from f402857 to f7cc345 Compare August 21, 2023 15:49
@nlsteers nlsteers marked this pull request as ready for review August 21, 2023 15:50
@nlsteers nlsteers force-pushed the pp-11314/metrics_release_process branch from f7cc345 to 7364c9b Compare August 21, 2023 15:58
@nlsteers
PP-11314 harden release workflow
ae833d1 
- check for concourse user when determining release workflow trigger
- prevent other merges when there is an open release pr
@nlsteers nlsteers force-pushed the pp-11314/metrics_release_process branch from 7364c9b to ae833d1 Compare August 21, 2023 16:12
@katstevens
Copy link
Contributor

katstevens commented Aug 22, 2023 •
edited
Loading

One last suggestion - can we add a Releasing section to the README describing how to go about it. Something like:

## Releasing

After a pull request is merged, Concourse will automatically create a new release pull request, that increments the version number. This pull request must be reviewed and merged by a developer. 

Once the release pull request is merged, Github Actions will publish the new versioned package to NPM.

Other pull requests will be blocked from merging until the release pull request is merged or closed.

katstevens
katstevens approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@katstevens katstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're looking good 👍 I guess you need to merge the other PR first!

@nlsteers nlsteers merged commit 988bc75 into main Aug 23, 2023
2 checks passed
@nlsteers nlsteers deleted the pp-11314/metrics_release_process branch August 23, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katstevens katstevens katstevens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlsteers @katstevens