Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the docs are shown, the Touch Bar should show a "Hide Docs" button #1645

Open
thomasio101 opened this issue Aug 20, 2021 · 30 comments
Open

Comments

@thomasio101
Copy link

Is your feature request related to a problem? Please describe.
I use Altair on my MacBook Pro and noticed that the Touch Bar is showing a "Show Docs" button, even when the docs are already shown.

Describe the solution you'd like
Whenever the docs are shown, the aforementioned button should say "Hide Docs".

Describe alternatives you've considered
I haven't considered any alternatives.

Additional context
When the app is showing the docs, like this:
Screenshot 2021-08-20 at 12 15 44
The touch bar still shows the "Show Docs" button:
Touch Bar Shot 2021-08-20 at 12 15 46

@imolorhe
Copy link
Collaborator

Thanks for reporting this! I'd look into it as soon as I can. Note you can also create a PR to resolve this issue faster.

@anonymous-baaka
Copy link

I would like to work on this issue. Do assign if no one else is working on it. @imolorhe

@imolorhe
Copy link
Collaborator

Feel free to work on it

@Aryan1982
Copy link

I would Like to work on this issue. @anonymous-baaka are you working on it?

@mani91g
Copy link

mani91g commented Apr 2, 2023

Has this been fixed? @imolorhe

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 2, 2023

@mani91g No it hasn't

@saikiran96
Copy link

Hello @imolorhe ,Can i pick this up??

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 2, 2023

@saikiran96 Please anyone can pick it up as it is not assigned.

joshwalters12 added a commit to joshwalters12/altair that referenced this issue Apr 7, 2023
…ic to only show 'Show Docs'/'Hide Docs', depending on the display status of the docs-viewer.
joshwalters12 added a commit to joshwalters12/altair that referenced this issue Apr 7, 2023
@SaunakNandi
Copy link

is it fixed?

@SaunakNandi
Copy link

@imolorhe can u tell me what are the packages that I have to install inorder to run the project?

@imolorhe
Copy link
Collaborator

imolorhe commented Sep 9, 2023

If you want to work on this, that means you're working on the electron app. To run that, you can run yarn install from the root of the repo to install the packages and autolink the packages. Then you should be able to go into packages/altair-electron and run yarn dev to get the local electron app running

@SaunakNandi
Copy link

@imolorhe can u tell me how to do the same thing in the GitHub cloudspace?

@Shwetapal9
Copy link

@imolorhe Can I take up this issue?

@abhisheksharma010
Copy link

Hello! I'm interested in working on this issue. Could someone please assign it to me or provide some guidance on how I can get started? Thanks!

@vaishnv-sn
Copy link

@imolorhe I'm taking on this issue.

@tanviagwl98
Copy link

Hi @imolorhe , I am unable to set up this project locally, after running yarn install my node modules are not getting installed. Can you suggest where I am missing the step?

@imolorhe
Copy link
Collaborator

@tanviagwl98 are you getting any errors?

@tanviagwl98
Copy link

Yes I am getting errors while installing to share screenshot I will have to run it again, will need sometime for that @imolorhe

@imolorhe
Copy link
Collaborator

Also are you running it in windows or mac?

@tanviagwl98
Copy link

It is on windows

@nishantguvvada
Copy link

@imolorhe Hi, I was trying to look into issue but can't get past the below error while running yarn dev :

$ yarn dev
yarn run v1.18.0
$ yarn compile && electron ./dist/
$ tsc && yarn sentry:sourcemaps:inject
src/app/actions.ts(6,34): error TS2307: Cannot find module '@altairgraphql/electron-settings-static' or its corresponding type declarations.
src/app/index.ts(12,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations.
src/app/window.ts(12,8): error TS2307: Cannot find module 'altair-static' or its corresponding type declarations.
src/app/window.ts(32,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations.
src/app/window.ts(33,29): error TS2307: Cannot find module 'altair-graphql-core/build/types/state/header.interfaces' or its corresponding type declarations.
src/app/window.ts(164,25): error TS7006: Parameter 'header' implicitly has an 'any' type.
src/electron-store-adapter/main-store-events.ts(1,30): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations.
src/settings/main/events.ts(7,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations.
src/settings/main/store.ts(5,8): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations.
src/utils/index.ts(6,40): error TS2307: Cannot find module '@altairgraphql/electron-interop' or its corresponding type declarations.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any suggestions on what am I missing?

@imolorhe
Copy link
Collaborator

@nishantguvvada did you already run yarn install from the root of the repo?

@nishantguvvada
Copy link

@imolorhe Encountered this error when running yarn install from the root of the repo (seems to be some issue with the version):

$ yarn install
yarn install v1.18.0
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning Resolution field "y18n@4.0.1" is incompatible with requested version "y18n@^5.0.5"
warning asar@3.2.0: Please use @electron/asar moving forward. There is no API change, just a package name change
warning babel-polyfill > core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
warning core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
warning dispensary@0.62.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
warning electron-notarize@1.2.2: Please use @electron/notarize moving forward. There is no API change, just a package name change
warning event-to-promise@0.8.0: Use promise-toolbox/fromEvent instead
warning flatten@1.0.3: flatten is deprecated in favor of utility frameworks such as lodash.
warning graphql-language-service-interface@2.10.2: this package has been merged into graphql-language-service
warning gulp-header@1.8.12: Removed event-stream from gulp-header
warning har-validator@5.1.5: this library is no longer supported
warning highlight.js@9.18.5: Support has ended for 9.x series. Upgrade to @latest
warning memfs@3.6.0: this will be v4
warning multer@1.4.4: Multer 1.x is affected by CVE-2022-24434. This is fixed in v1.4.4-lts.1 which drops support for versions of Node.js before 6. Please upgrade to at least Node.js 6 and version 1.4.4-lts.1 of Multer. If you need support for older versions of Node.js, we are open to accepting patches that would fix the CVE on the main 1.x release line, whilst maintaining compatibility with Node.js 0.10.
warning ngx-take-until-destroy@5.4.0: Important: For Angular v9+ please use the until-destroy library: https://github.com/ngneat/until-destroy\#use-with-ivy
warning Resolution field "oauth@0.10.0" is incompatible with requested version "oauth@0.9.x"
warning Resolution field "oauth@0.10.0" is incompatible with requested version "oauth@0.9.x"
warning Resolution field "oauth@0.10.0" is incompatible with requested version "oauth@0.9.x"
warning protractor@7.0.0: We have news to share - Protractor is deprecated and will reach end-of-life by Summer 2023. To learn more and find out about other options please refer to this post on the Angular blog. Thank you for using and contributing to Protractor. https://goo.gle/state-of-e2e-in-angular
warning querystring@0.2.1: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
warning readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
warning request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see request/request#3142
warning rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
warning sign-addon@3.11.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
warning smartwrap@1.2.5: Backported compatibility to node > 6
warning source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
warning string-similarity@4.0.4: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
error Couldn't find any versions for "string-width-cjs" that matches "^4.2.3"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@imolorhe
Copy link
Collaborator

@nishantguvvada Did you modify the yarn.lock file? Seems you have an issue with the dependency version resolution.

@utkarshilh
Copy link

I want to work for the issue .. Does this issue is already resolved if not allow me contribute

@nehagupta1504
Copy link

How Do We get the touchbar As I can't see nay when I downloaded it
image

@akhilk2802
Copy link

Is this issue resolved ? i am interested to work on it, Please assign

@sudeep-h
Copy link

sudeep-h commented Oct 8, 2024

I am interested to work in this issue, can you please assign it to me @imolorhe.

@TomiDevops
Copy link

I am new to open source contribution. Can i take on this challenge?

1 similar comment
@Thintalltom
Copy link

I am new to open source contribution. Can i take on this challenge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests