Open
Conversation
added 7 commits
February 8, 2026 14:20
ysw789
requested changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
- 이메일 인증 Rate Limit 구현은 아주 잘 하셨습니다~
- 지금은 이메일 발송할 때 성공 / 작업 진행중인 내역도
log.info()로 로그에 남게 하고 있는데, 실패한 것만 로그에 남기면 어떨까 합니다. 성공한 것도 로깅하면 너무 과도하게 로그가 찍힐 것 같습니다. - 클래스 네이밍에서
Port는 저희 프로젝트에서 사용하지 않는 네이밍입니다. 기존 outbound 포트 관례에 맞게 아래와 같이 수정해 주세요.기존 패턴 domain/notification/port/outbound/NotificationRepository.java ← 영속성 domain/notification/port/outbound/NotificationQueryRepository.java ← 쿼리 domain/auth/port/outbound/KakaoAuthClient.java ← 외부 API 변경 요청 EmailSendLogPort → EmailSendLogRepository EmailVerificationTokenStorePort → EmailVerificationTokenStoreRepository EmailSenderPort → EmailClient (KakaoAuthClient, AppleAuthClient 패턴 참고) - 추가된 env 값은 노션 문서에 최신화 해주시고, DB 마이그레이션 DDL은 작업 문서에 남겨주세요
...om/dreamteam/alter/adapter/outbound/email/redis/RedisEmailVerificationTokenStoreAdapter.java
Outdated
Show resolved
Hide resolved
...n/java/com/dreamteam/alter/adapter/inbound/general/user/controller/UserPublicController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/adapter/inbound/general/user/dto/CreateUserRequestDto.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/adapter/outbound/aws/ses/properties/AwsProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/adapter/outbound/aws/ses/SesEmailSenderAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/application/email/usecase/SendEmailVerificationCode.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 문서
https://www.notion.so/BE-2f6865531628807ca2efc9313180e45c?source=copy_link