misc tweaks #9
Open
misc tweaks #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, mimeType support wildcards, so announce we can handle "text/*". Secondly, some mail-attachments i receive are text but are classified as application/octet-stream, so add that, too, so i can view them. Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Allow to backup user preferences. This setting is on per default but lint complains if you rely on the default and not specify it explicitly.. Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
The version is informational only so disable it for clarity. Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
lint was complaining that the fontsizes were not translated in ja. Change this to use a NumberPicker instead of the hardcoded array. Note: requires minSdkVersion bump to 11 Note: fontsize should really not be a string preference! Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, nice app! I like it's size.
There are, however, a couple of nits:
First and foremost, many of my mail-attachments are text/x-patch or text/x-diff, some are even application/octet-stream depending on the MUA deciding how to obfuscate the attached patches.
To be able to read them, i need an app that registers for all these mimeTypes. That patch in this series is the most important for me. I would be grateful if you would consider applying at least this one.
The other stuff fell out while i tried to rebuild your Text Viewer :)
Thanks alot in advance for your time!
Cheers,