Fix: Future instantiation in parallel_calculate_chunks for correct cl…#2760
Open
gitgud5000 wants to merge 1 commit intoalteryx:mainfrom
Open
Fix: Future instantiation in parallel_calculate_chunks for correct cl…#2760gitgud5000 wants to merge 1 commit intoalteryx:mainfrom
gitgud5000 wants to merge 1 commit intoalteryx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR resolves an issue in Featuretools where using
distributed>=2024.8.2causes a crash due to an incorrect instantiation ofFuturewithout passing aclientinstance.🔧 Bug Description
As reported by @BohdanBilonoh, the latest Featuretools release fails when used with Dask versions
>=2024.8.2. The issue occurs due to the following line incalculate_feature_matrix.py:https://github.com/kedro-org/kedro-plugins/blob/552b973a256c0f4a9f96e36feb70f4fc15fb371b/kedro-datasets/kedro_datasets/tensorflow/tensorflow_model_dataset.py#L168-L172
featuretools/featuretools/computational_backends/calculate_feature_matrix.py
Lines 746 to 748 in 938a0f6
The above code leads to an
AttributeErrorbecause Dask's API now requiresFutureto be explicitly associated with aclientinstance.Fix Implementation
Updating the
Futureinstantiation to include theclientresolves the issue:Testing & Verification
featuretools==1.31.0anddistributed==2025.2.0.References & Related Issues
Issue: #2733
Related Dask Function:
[distributed.client.py#L322](https://github.com/dask/distributed/blob/7ab72493b6df194bf6cb86ec1c4ac7c27cf1b3a1/distributed/client.py#L322)Error
View log output
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request.