Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed AltDialog UI #1589

Merged
merged 8 commits into from
May 9, 2024
Merged

Changed AltDialog UI #1589

merged 8 commits into from
May 9, 2024

Conversation

andreion1ca
Copy link
Contributor

No description provided.

@andreion1ca andreion1ca linked an issue May 2, 2024 that may be closed by this pull request
Modify the UI of the AltDialog #1583
Closed
@rucindrea
Copy link
Contributor

The new style looks great!

A few questions / comments:

  • If we want to include it in the coming release, we could change the tab name to something like "Cloud (coming soon)" to indicate that this is not supposed to work yet
  • Do we have separate tickets for all the other changes needed for this to actually work?
  • Do we want this ticket to include the changes that we need on the AltTester Editor window, for example a field where to set the license key and a way to say you want the build to connect to cloud server automatically?

@andreion1ca
Copy link
Contributor Author

The new style looks great!

A few questions / comments:

  • If we want to include it in the coming release, we could change the tab name to something like "Cloud (coming soon)" to indicate that this is not supposed to work yet
  • Do we have separate tickets for all the other changes needed for this to actually work?
  • Do we want this ticket to include the changes that we need on the AltTester Editor window, for example a field where to set the license key and a way to say you want the build to connect to cloud server automatically?
  • I will modify the Cloud tab name in order to indicate that it is a coming feature in a separate commit to this PR
  • This is the issue that includes the changes needed for the Cloud tab to work
  • I will move the changes needed on the AltTester Editor window to the issue specified before

@iulianatodoran iulianatodoran merged commit 77805c8 into development May 9, 2024
11 checks passed
@iulianatodoran iulianatodoran deleted the 1583-modify-the-ui-of-the-altdialog branch May 9, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulianatodoran iulianatodoran iulianatodoran approved these changes

@rucindrea rucindrea rucindrea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify the UI of the AltDialog
3 participants
@andreion1ca @rucindrea @iulianatodoran