refactor: app hotspots testable patterns#104
Open
kangeunchan wants to merge 4 commits intoaltuslabsxyz:mainfrom
Open
refactor: app hotspots testable patterns#104kangeunchan wants to merge 4 commits intoaltuslabsxyz:mainfrom
kangeunchan wants to merge 4 commits intoaltuslabsxyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors three high-complexity hotspots into explicit, testable patterns while preserving runtime behavior:
It also includes dependency metadata updates in
go.mod/go.sumfor newly direct imports used by the refactor.Scope
internal/application/upgrade/resumable_execute.gointernal/application/devnet/provision.gointernal/daemon/server/server.goKey Changes
1) Upgrade resumable execution (state machine)
switch/fallthroughflow with stage handler map + loop orchestration2) Provision use case (pipeline)
ProvisionUseCase.Executeinto step functions:prepareMetadatafetchGenesisinitializeKeysAndNodespatchGenesispersistStateExecute3) Daemon server initialization (builder)
ServerBuilderwithWith*methods andBuild()multierrTests Added
internal/application/upgrade/resumable_execute_state_machine_test.gointernal/application/devnet/provision_pipeline_test.gointernal/daemon/server/server_builder_test.goValidation
go test ./internal/application/upgrade/...go test ./internal/application/devnet/...go test ./internal/daemon/server/...Complexity / LOC (post-refactor)
executeWithGovResumable: CC=7, LOC=32ProvisionUseCase.Execute: CC=5, LOC=22server.New: CC=1, LOC=11Compatibility