Support DT.BIN field length data type during parsing #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary with iso data
Pull changes from aguirrel/py8583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I did some changes to further support parsing of binary-encoded ISO 8583 messages. Currently, when parsing variable length fields (LLVAR or LLLVAR),
DT.BINlength types are ignored, so the actual length of the field is not getting parsed.BTW, I pulled @aguirrel's changes into my own fork as I'm encountering an error when importing
py8583specfrom a test project. Can you tell me how to import the library from other projects using the currentmasterimplementation?Thanks!