Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump elasticsearch from 8.12.0 to 8.12.1 in /examples/skywalking #1079

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/skywalking/Dockerfile-elasticsearch
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM elasticsearch:8.12.0@sha256:2529e4b8062e4b9f0a31bea3ee797a58dae4cfe2d2b5879b4a1b03250c7ad31c
FROM elasticsearch:8.12.1@sha256:8c18a68f086b0935c56a7d6fb02e602fc0e2265a31668c6679c7d159a302b1c1
2 changes: 1 addition & 1 deletion mobile/library/common/internal_engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ envoy_status_t InternalEngine::terminate() {

bool InternalEngine::isTerminated() const { return terminated_; }

InternalEngine::InternalEngine() {
InternalEngine::~InternalEngine() {
if (!terminated_) {
terminate();
}
Expand Down
2 changes: 1 addition & 1 deletion mobile/library/common/internal_engine.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class InternalEngine : public Logger::Loggable<Logger::Id::main> {
/**
* InternalEngine destructor.
*/
InternalEngine();
~InternalEngine();

/**
* Run the engine with the provided configuration.
Expand Down