Optimization: extensive null checks #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vate ErrorOr(List<Error> errors)
private ErrorOr(List<Error> errors)
{
if (errors is null)
{
throw new ArgumentNullException(nameof(errors));
}
if (errors is null || errors.Count == 0)
{
throw new ArgumentException("Cannot create an ErrorOr<TValue> from an empty collection of errors. Provide at least one error.", nameof(errors));
}
_errors = errors;
}
This check is unnecessary due to the one performed just above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection constructor is called from two places: implicit conversion from list of error and from array of errors. I have noticed that implicit conversion from array of errors has its own null check so effectively it is done twice. I have added null check in implicit conversion from list of errors and removed one from constructor. Additionally I have fixed inaccurate array converter description and moved Value constructor at the top of constructor block.
Contains #128