forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exports Entity for awsemfexporter plugins on PutLogEvent calls #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadpatel
reviewed
Sep 16, 2024
chadpatel
reviewed
Sep 16, 2024
This reverts commit 76f1547.
chadpatel
reviewed
Sep 18, 2024
chadpatel
reviewed
Sep 18, 2024
chadpatel
reviewed
Sep 18, 2024
chadpatel
reviewed
Sep 18, 2024
chadpatel
reviewed
Sep 18, 2024
…comments, small fixes.
chadpatel
approved these changes
Sep 19, 2024
nathalapooja
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, assuming the least used pusher, will not have any logs pending publishing to PLE
movence
added a commit
to movence/opentelemetry-collector-contrib
that referenced
this pull request
Oct 1, 2024
Merged
movence
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Exports Entity for awsemfexporter on PutLogEvent calls
.We now add Entity as part of the StreamKey to pass the unique Identity to the proper Log Group and Log Stream. As a result, the pusher map is now bounded (currently 1000) using an lru cache to prevent potential memory exhaustion with the added cardinality.
Testing: Unit testing was added. Manual testing was done on personal EC2 instance and EKS Cluster, using a basic Application Signals instance on the cloudwatch agent.
On EC2
On EKS, with some added debug lines
I currently do not have access to the Entity experience, but can confirm that metrics continue to publish