Adds support for builder API generation in Java #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds nested builder class * `build` mehtod verifies required/optional fields * `readFrom` usess new builder to create an instance of the class
zslayton
approved these changes
Oct 18, 2024
popematt
reviewed
Oct 18, 2024
| @@ -17,7 +17,7 @@ import java.io.IOException; | |||
| class {{ model.name }} { | |||
| private java.util.ArrayList<{{ sequence_info["element_type"] | fully_qualified_type_name }}> value; | |||
|
|
|||
| public {{ model.name }}() {} | |||
| private {{ model.name }}() {} | |||
|
|
|||
| public java.util.ArrayList<{{ sequence_info["element_type"] | fully_qualified_type_name }}> getValue() { | |||
There was a problem hiding this comment.
I'm sorry I missed this earlier. When working with Java collections, you should use the widest acceptable interface for the use case in the API (so List in this case) and use the specific implementation only when you're actually constructing a new instance.
There was a problem hiding this comment.
BTW, It's fine if you want to follow up on this in another PR.
popematt
reviewed
Oct 21, 2024
popematt
approved these changes
Oct 21, 2024
desaikd
added a commit
to desaikd/ion-cli
that referenced
this pull request
Nov 1, 2024
desaikd
added a commit
that referenced
this pull request
Nov 1, 2024
* Adds new model changes for `Structure` (#138) * Adds new model changes for scalar (#143) * Adds changes for sequence data type (#144) * Adds tests for new model changes (#146) * Adds new model changes for Rust code generation (#147) * Adds changes for optional/required fields in Java code generation (#148) * Modifies generated setter API to take nested types instead of nested properties (#153) * Adds support for builder API generation in Java (#154) * Adds support for Java enum generation (#158) * Adds namespace fix for nested sequence and adds support for nested types in Sequence and Scalar ADT (#163) * Adds changes for nested type naming (#166) * Adds support for imports in code generation (#169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #97
Description of changes:
This PR adds support for builder API generation in Java.
Generated code in Java:
Generated code adds builder API support which can be found here.
List of changes:
buildmehtod verifies required/optional fieldsreadFromusess new builder to create an instance of the classBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.