Adds README for code generation #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Nov 5, 2024
popematt
reviewed
Nov 5, 2024
Comment on lines
347
to
349
| let mut reader: Reader = ReaderBuilder::new().build(ION_DATA) ?; | ||
| reader.next() ?; | ||
| let foo: Foo = Foo::read_from( & mut reader) ?; |
There was a problem hiding this comment.
Any particular reason for the added spaces here?
There was a problem hiding this comment.
huh. I removed those spaces. I think its getting formatted because I added rust syntax highlighting and this code block does not really contain a main. I will just remove the highlight I think.
desaikd
force-pushed
the
code-gen-README
branch
from
b72b043
to
b84e8a2
Compare
desaikd
force-pushed
the
code-gen-README
branch
from
b84e8a2
to
1ef172b
Compare
popematt
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR creates a README for code generation.
List of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.