Fix release workflow #159
Merged
Fix release workflow #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
This PR addresses some issues found in the release workflow while attempting to release v1.3.1.
The C# project is configured to use framework 7, which was not installed with the release workflow's setup-dotnet actions, so this PR adds 7.0 to the framework list to install in each matrix configuration, reflecting the changes to unit testing in #154.
This PR also updates the actions used in the release workflow, and addresses spellcheck issues found by actionlint, where variables were not quoted and could lead to unexpected behaviors.
It would be great to have the ability to run the release workflow prior to an actual release, so that we can ensure everything is working. I'm thinking we might be able to setup the release workflow to execute everything up to
Publish to NuGeton any commit. Then only execute the publish with a new version release.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.