Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readers for annotations and contains constraints #267

Merged
merged 1 commit into from
May 26, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

#256

Description of changes:

Adds readers for Annotations (v2) and Contains constraints. Updates ReaderTests.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from desaikd May 25, 2023 18:56
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 96.29% and project coverage change: +0.45 🎉

Comparison is base (b774d33) 82.84% compared to head (7d82c40) 83.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   82.84%   83.29%   +0.45%     
==========================================
  Files         129      131       +2     
  Lines        3176     3203      +27     
  Branches      750      756       +6     
==========================================
+ Hits         2631     2668      +37     
+ Misses        322      310      -12     
- Partials      223      225       +2     
Impacted Files Coverage Δ
...reader/internal/constraints/AnnotationsV2Reader.kt 94.73% <94.73%> (ø)
...amazon/ionschema/reader/internal/TypeReaderV2_0.kt 90.27% <100.00%> (-2.58%) ⬇️
...hema/reader/internal/constraints/ContainsReader.kt 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@popematt popematt merged commit f32fca9 into amazon-ion:master May 26, 2023
@popematt popematt deleted the read-annotations-and-contains branch May 26, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants