Extend patches for additional Dockerfiles #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timesler
force-pushed
the
timesler/update-harness-to-use-prebuilt-images
branch
from
7574f6e to
7ce7b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR reuses several of the existing "fix_* bash methods to patch additional instance which have unbuildable dockerfiles.
@mshihabr these fixes should probably also be made at the source in the HF dataset
I'll create this as a draft, but no need to merge if we update the Dockerfiles themselves instead
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.