Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding for int contexts #227

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Fix padding for int contexts #227

merged 7 commits into from
Dec 4, 2024

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Dec 4, 2024

Issue #, if available: On Linux, the final call to .to creates trouble when input tensors are integer. For example:

>>> a = torch.tensor([1])
>>> b = torch.stack([torch.full((1,), torch.nan), a])
>>> b
tensor([[nan],
        [1.]])
>>> b.to(a)
tensor([[-9223372036854775808],
        [                   1]])

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lostella lostella added the bugfix Contains a bug fix label Dec 4, 2024
@lostella lostella requested a review from abdulfatir December 4, 2024 15:11
@lostella lostella added the run-eval Run evaluation CI workflow label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Evaluation Metrics

dataset model MASE WQL
ETTh amazon/chronos-bolt-small 0.7926730942104143 0.0758716069320084
monash_covid_deaths amazon/chronos-bolt-small 36.493518307543425 0.042877919416108884
monash_fred_md amazon/chronos-bolt-small 0.6078560573864246 0.037209082585979034
monash_m3_quarterly amazon/chronos-bolt-small 1.3265166541479965 0.07691622044314622
monash_nn5_weekly amazon/chronos-bolt-small 0.9263145837443125 0.08449630835522395
monash_tourism_yearly amazon/chronos-bolt-small 3.8949207098279794 0.16770225156548993
taxi_30min amazon/chronos-bolt-small 0.7596661850405324 0.23481502423492318

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Evaluation Metrics

dataset model MASE WQL
ETTh amazon/chronos-bolt-small 0.7926730942104143 0.0758716069320084
monash_covid_deaths amazon/chronos-bolt-small 36.493518307543425 0.042877919416108884
monash_fred_md amazon/chronos-bolt-small 0.6078560573864246 0.037209082585979034
monash_m3_quarterly amazon/chronos-bolt-small 1.3265166541479965 0.07691622044314622
monash_nn5_weekly amazon/chronos-bolt-small 0.9263145837443125 0.08449630835522395
monash_tourism_yearly amazon/chronos-bolt-small 3.8949207098279794 0.16770225156548993
taxi_30min amazon/chronos-bolt-small 0.7596661850405324 0.23481502423492318

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Evaluation Metrics

dataset model MASE WQL
ETTh amazon/chronos-bolt-small 0.7926730942104143 0.0758716069320084
monash_covid_deaths amazon/chronos-bolt-small 36.493518307543425 0.042877919416108884
monash_fred_md amazon/chronos-bolt-small 0.6078560573864246 0.037209082585979034
monash_m3_quarterly amazon/chronos-bolt-small 1.3265166541479965 0.07691622044314622
monash_nn5_weekly amazon/chronos-bolt-small 0.9263145837443125 0.08449630835522395
monash_tourism_yearly amazon/chronos-bolt-small 3.8949207098279794 0.16770225156548993
taxi_30min amazon/chronos-bolt-small 0.7596661850405324 0.23481502423492318

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Evaluation Metrics

dataset model MASE WQL
ETTh amazon/chronos-bolt-small 0.7926730942104143 0.0758716069320084
monash_covid_deaths amazon/chronos-bolt-small 36.493518307543425 0.042877919416108884
monash_fred_md amazon/chronos-bolt-small 0.6078560573864246 0.037209082585979034
monash_m3_quarterly amazon/chronos-bolt-small 1.3265166541479965 0.07691622044314622
monash_nn5_weekly amazon/chronos-bolt-small 0.9263145837443125 0.08449630835522395
monash_tourism_yearly amazon/chronos-bolt-small 3.8949207098279794 0.16770225156548993
taxi_30min amazon/chronos-bolt-small 0.7596661850405324 0.23481502423492318

abdulfatir
abdulfatir reviewed Dec 4, 2024
View reviewed changes
test/test_utils.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Evaluation Metrics

dataset model MASE WQL
ETTh amazon/chronos-bolt-small 0.7926730942104143 0.0758716069320084
monash_covid_deaths amazon/chronos-bolt-small 36.493518307543425 0.042877919416108884
monash_fred_md amazon/chronos-bolt-small 0.6078560573864246 0.037209082585979034
monash_m3_quarterly amazon/chronos-bolt-small 1.3265166541479965 0.07691622044314622
monash_nn5_weekly amazon/chronos-bolt-small 0.9263145837443125 0.08449630835522395
monash_tourism_yearly amazon/chronos-bolt-small 3.8949207098279794 0.16770225156548993
taxi_30min amazon/chronos-bolt-small 0.7596661850405324 0.23481502423492318

@lostella lostella merged commit 67f0084 into amazon-science:main Dec 4, 2024
6 checks passed
@lostella lostella deleted the fix-padding branch December 4, 2024 15:46
@abdulfatir abdulfatir mentioned this pull request Dec 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulfatir abdulfatir abdulfatir approved these changes

Assignees
No one assigned
Labels
bugfix Contains a bug fix run-eval Run evaluation CI workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lostella @abdulfatir