Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation issues #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubhamugare
Copy link

Description of changes:

Currently, the installation of the mxeval package requires using the cloned repository. This is not ideal for other tools that will use mxeval. This PR simplifies the installation such that one can simply use pip install git+https://github.com/amazon-science/mxeval.git for installation.

The PR includes following changes:

  1. Changes in setup.py to enable above.
  2. Move the data directory inside the mxeval module. Updated paths in the code where data is accessed accordingly. This is necessary since the installed module will now contain the data directory.

Test:
I'm working on a tool that uses this dependency. I have tested that I could import mxeval humaneval and mbpp.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ens-lg4
Copy link

ens-lg4 commented Jul 17, 2024

I support this merge request.

Was about to make a similar one, then found out someone was thinking the same, but half a year earlier!

@shubhamugare
Copy link
Author

I think they are not actively looking at the repository anymore. You can just use my fork as I did here. :)

@ens-lg4
Copy link

ens-lg4 commented Jul 17, 2024

You can just use my fork as I did here. :)

Thanks!
This almost exactly what I just did (only with axs integration) :

axs byquery python_package,package_name=mxeval,installable=git+https://github.com/shubhamugare/mxeval.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants