Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move duplicated function in separate file #458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move duplicated function in separate file #458

wants to merge 1 commit into from

Conversation

SigismundSchlomo
Copy link
Contributor

Why

Code duplication is a bad practice

What was done

  • Duplicated function was moved to separate file

Checklist:

  • Code follows the style guidelines
  • Documentation updated
  • Corner cases evaluated and handled
  • Automatic tests added/update
  • Automatic tests pass
  • Software runs (locally or hosted)
  • Sanity check passed
  • Self-review passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAR2 AndrewAR2 AndrewAR2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SigismundSchlomo @AndrewAR2