Setup SNP on the RHEL host #15

LakshmiSaiHarika · 2024-08-12T21:38:58Z

Updated snp.sh to install dependencies, build SNP latest kernel package and set the default grub menu to the SNP latest kernel version in RHEL (Tested this on RHEL 9.4)

ryansavino · 2024-08-12T21:44:51Z

docs/snp.md

@@ -51,6 +52,11 @@ Download the script and add the execute permission:
 wget https://github.com/amd/sev-utils/raw/main/tools/snp.sh
 chmod +x snp.sh
 ```
+For RHEL OS distribution, export the following environment variables for using your RHEL subscription manager credentials for installing the package dependencies:


This shouldn't be necessary. If you're installing packages on the host, let it error out if subscription manager isn't enabled.

Done, I removed this portion

I still see the variables and method to register the subscription manager.

ryansavino · 2024-08-12T21:45:19Z

tools/snp.sh

@@ -90,6 +90,10 @@ QEMU_CMDLINE_FILE="${QEMU_CMDLINE:-${LAUNCH_WORKING_DIR}/qemu.cmdline}"
 IMAGE="${IMAGE:-${LAUNCH_WORKING_DIR}/${GUEST_NAME}.img}"
 GENERATED_INITRD_BIN="${SETUP_WORKING_DIR}/initrd.img"

+# Redhat Sensitive Credentials -- User must specify, no default value set


See docs comment. Shouldn't be needed.

Done, I removed this line

ryansavino · 2024-08-12T21:47:39Z

tools/snp.sh

@@ -214,7 +215,41 @@ install_sev_snp_measure() {
  pip install sev-snp-measure==${SEV_SNP_MEASURE_VERSION}
 }

-install_dependencies() {
+check_if_redhat_credentials_set(){


Instead, maybe have a function to check if the subscription manager is registered and working before proceeding.

Created check_rhel_subscription_mgr_status() to check the status, if status is in unregister keyterms, then register RHEL subscription with the given RHEL env variables

ryansavino · 2024-08-12T21:48:36Z

tools/snp.sh

-  #sudo apt install -y nasm
+
+  # Remove any default nasm package
+  sudo apt purge nasm


why do we need this?

Removed this line as this works on fresh os image

ryansavino · 2024-08-12T21:49:44Z

tools/snp.sh

@@ -268,10 +319,110 @@ install_dependencies() {

  # pip needed for sev-snp-measure
  sudo apt install -y python3-pip
+}
+
+check_if_redhat_credentials_set(){


Do you have this method twice?

Done.. I cleaned this portion

ryansavino · 2024-08-12T21:55:28Z

tools/snp.sh

+    # genisoimage utility supported until RedHat version 8
+    # For genisoimage utility support in RedHat 9, using epel
+  sudo dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm
+  sudo dnf install -y genisoimage


we need to avoid adding a repo (esp epel) unless completely necessary. Let's try to resolve this to an existing package. If not, I'll help you find a solution.

Right now removing genisoimage from this PR (RHEL setup host PR) as this package is used in the launch-guest process..

I will update further dependencies for the SNP guest launch in the future PR

ryansavino · 2024-08-12T21:55:42Z

tools/snp.sh

 }

+


Done.. I cleaned this up

ryansavino · 2024-08-12T21:56:56Z

tools/snp.sh

@@ -1113,6 +1264,7 @@ main() {
      ;;

    setup-host)
+      identify_linux_distribution_type


Maybe we run this, only when needed?

Done.. I updated this

ryansavino · 2024-08-12T21:57:32Z

tools/snp.sh

-AMDSEV_URL="https://github.com/ryansavino/AMDSEV.git"
-AMDSEV_DEFAULT_BRANCH="snp-latest-fixes"
+AMDSEV_URL="https://github.com/LakshmiSaiHarika/AMDSEV.git"
+AMDSEV_DEFAULT_BRANCH="rhel-snp-latest-fixes"


what changes here? If not too involved maybe we can merge into my existing fork.

AMDESE changes: In your fork, I added few fixes fir RHEL in build and install script

I raised a PR (below link) to merge in your AMDESE fork:
ryansavino/amdese-amdsev#1

ryansavino · 2024-08-12T22:01:26Z

tools/snp.sh

@@ -465,6 +465,28 @@ set_grub_default_snp() {
  sudo update-grub
 }

+grubby_to_set_grub_default_snp(){


grubby_set...

Removed grubby from this script

Modified RHEL grub configuration and reloaded settings in "rhel_set_grub_default_snp"

ryansavino · 2024-08-20T20:37:06Z

tools/snp.sh

+    rhel)
+    LINUX_TYPE='rhel'
+
+    if [[ "$UPM" = false ]]; then


This check doesn't belong here. You can run a similar failure case outside this function somewhere if you want to make sure rhel doesn't proceed.

Missing break for rhel case.

indent under each category.

ryansavino · 2024-09-11T20:00:20Z

docs/snp.md

@@ -51,6 +52,11 @@ Download the script and add the execute permission:
 wget https://github.com/amd/sev-utils/raw/main/tools/snp.sh
 chmod +x snp.sh
 ```
+For RHEL OS distribution, export the following environment variables for using your RHEL subscription manager credentials for installing the package dependencies:


I still see the variables and method to register the subscription manager.

Added RHEL 9.4 OS as one of the tested OS distribution for sev-utils Signed-off-by: Harika Nittala <lnittala@amd.com>

LakshmiSaiHarika · 2024-09-17T00:38:09Z

tools/snp.sh

-AMDSEV_URL="https://github.com/ryansavino/AMDSEV.git"
-AMDSEV_DEFAULT_BRANCH="snp-latest-fixes"
+AMDSEV_URL="https://github.com/LakshmiSaiHarika/AMDSEV.git"
+AMDSEV_DEFAULT_BRANCH="rhel-setup-host"


@ryansavino Please review and merge my PR for adding minor RHEL fixes into your AMDESE fork
PR link: here

Renamed old install_dependencies feature to ubuntu_install_dependencies Updated install_dependencies to perform installation of dependencies based on identified linux distribution and their package manager command Signed-off-by: Harika Nittala <lnittala@amd.com>

Removed ubuntu nasm package uninstallation step from the nasm source installation process Signed-off-by: Harika Nittala <lnittala@amd.com>

…build Added RHEL dependencies to build the SNP kernel rpm package for the host and guest Signed-off-by: Harika Nittala <lnittala@amd.com>

Generalized set_default_grub_menu across various OS distribution Renamed ubuntu_set_default_grub_menu to set specific default ubuntu grub menu to the built SNP kernel Added a function to set the RHEL default grub menu to the built SNP kernel Signed-off-by: Harika Nittala <lnittala@amd.com>

Modified AMDSEV URL to add RHEL fixes for the latest SNP kernel patches, qemu build on the RHEL OS Requested code merge into ryan's latest fix issues branch for the updated AMD_SEV_URL in sev-utils Signed-off-by: Harika Nittala <lnittala@amd.com>

ryansavino requested changes Aug 12, 2024

View reviewed changes

LakshmiSaiHarika force-pushed the rhel-changes branch from a70f31b to 9873fe7 Compare August 19, 2024 23:18

LakshmiSaiHarika force-pushed the rhel-changes branch from 9873fe7 to 27be224 Compare September 5, 2024 22:44

ryansavino requested changes Sep 11, 2024

View reviewed changes

Update snp docs for RHEL

fdd5bd4

Added RHEL 9.4 OS as one of the tested OS distribution for sev-utils Signed-off-by: Harika Nittala <lnittala@amd.com>

LakshmiSaiHarika force-pushed the rhel-changes branch from 27be224 to b54dd14 Compare September 17, 2024 00:33

LakshmiSaiHarika commented Sep 17, 2024

View reviewed changes

LakshmiSaiHarika added 5 commits September 19, 2024 06:33

snp.sh: Remove nasm package uninstallation step

7a5fe80

Removed ubuntu nasm package uninstallation step from the nasm source installation process Signed-off-by: Harika Nittala <lnittala@amd.com>

snp.sh: Add Redhat dependencies installation prior to the SNP kernel …

ae2466c

…build Added RHEL dependencies to build the SNP kernel rpm package for the host and guest Signed-off-by: Harika Nittala <lnittala@amd.com>

LakshmiSaiHarika force-pushed the rhel-changes branch from b54dd14 to 876b7f7 Compare September 19, 2024 07:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup SNP on the RHEL host #15

Setup SNP on the RHEL host #15

LakshmiSaiHarika commented Aug 12, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Sep 11, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024 •

edited

Loading

ryansavino Aug 12, 2024

LakshmiSaiHarika Sep 5, 2024

ryansavino Aug 20, 2024

ryansavino Sep 11, 2024

LakshmiSaiHarika Sep 17, 2024

Setup SNP on the RHEL host #15

Are you sure you want to change the base?

Setup SNP on the RHEL host #15

Conversation

LakshmiSaiHarika commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LakshmiSaiHarika Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LakshmiSaiHarika Sep 5, 2024 •

edited

Loading