[FIX] Package not working on latest version of RN library#1
Open
jgtoriginal wants to merge 2 commits intoamerllica:masterfrom
Open
[FIX] Package not working on latest version of RN library#1jgtoriginal wants to merge 2 commits intoamerllica:masterfrom
jgtoriginal wants to merge 2 commits intoamerllica:masterfrom
Conversation
Owner
|
Dear @jgtoriginal I just saw this PR, really really I'm sorry. I'll try to reorder everything from scratch and definitely add you as a contributor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package had some incompatibilities with the latest Android API, for which it would not work on the latest version of React Native. Did couple of changes to make it work.
Also, it's been hard to track this repository, because it's not linked on the npmjs.com package information. It would be good to have that link so as it's easier for other developers to find this repository an collaborate.