Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gravity task #41

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Fix gravity task #41

merged 5 commits into from
Sep 9, 2024

Conversation

davidegorbani
Copy link
Collaborator

@davidegorbani davidegorbani commented Aug 20, 2024

With this PR I fixed the bug in the gravity task; basically, the gravity task implemented in blf requires the direction vector to be in body-frame while the one that was set was in world-frame. Moreover, I fixed the t-pose calibration of the feet; now, when the t-pose is performed, the setpoint of the floor contact task is recomputed starting from the t-pose position.

@davidegorbani
Copy link
Collaborator Author

The macos CI is failing, I compared the micromamba list of the failing CI with one of a successful CI and I noticed that qt6-main is missing in the failing CI; should I add it as a dependency in here @traversaro?

@traversaro
Copy link
Contributor

The macos CI is failing, I compared the micromamba list of the failing CI with one of a successful CI and I noticed that qt6-main is missing in the failing CI; should I add it as a dependency in here @traversaro?

I actually think you just need to set the env variable QT_HOST_PATH to $CONDA_PREFIX just on macos, this is due to https://github.com/conda-forge/qt-main-feedstock/issues .

@davidegorbani
Copy link
Collaborator Author

Closing as the CI is fixed now; thank you @traversaro @Gianlucamilani!

@davidegorbani davidegorbani merged commit 6ddc292 into main Sep 9, 2024
6 checks passed
@davidegorbani davidegorbani deleted the fix_gravity_task branch September 9, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working phase:implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants