Fix clearCalibrationMatrices #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
reviewed
Sep 20, 2024
Comment on lines
136
to
139
| manif::SO3d IMU_R_link; // Rotation matrix from the IMU to related link, set through config | ||
| // file | ||
| manif::SO3d IMU_R_link_init; // Rotation matrix from the IMU to related link, set through config | ||
| // file |
There was a problem hiding this comment.
The two descriptions are the same?
There was a problem hiding this comment.
I just copied from the line above and forgot to change it, fixed it with 28ee781.
traversaro
approved these changes
Sep 20, 2024
Gianlucamilani
approved these changes
Sep 20, 2024
|
Thanks! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the value of the calibration matrix$^{IMU}R_{link}$ is set to the value read from the configuration file when the method
clearCalibrationMatricesis called.