Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a clone of the input data array at row 0 prior to swapping ele… #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WingChoi
Copy link

…ments

The original line 51 in index.js creates a reference of data[0] and puts it in header.
elements 3, 4 isn't swapped with elements 5, 6. You would end up with:
elements 5, 6, 5, 6 instead.

This change would use .slice() call to create a shallow copy of data[0].
The swap will now be successful.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c19a9d8 on WingChoi:master into 53b0db6 on amida-tech:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants