Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds strong Helm chart input validation and normalization for key ChromaDB parameters to prevent misconfiguration at install/upgrade time (per #96), and wires the normalized values through rendered manifests and v1 server config generation.
Changes:
- Introduces Helm helper templates to validate/normalize
chromadb.allowReset,chromadb.isPersistent, andchromadb.persistDirectory. - Uses normalized values when rendering StatefulSet env vars, PVC creation, and volume mounts.
- Extends regression tests and updates README examples/docs to reflect accepted inputs and normalization behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_v1_config.sh |
Adds test helpers and regression cases for valid/invalid boolean strings and persist directory path validation. |
charts/chromadb-chart/templates/statefulset.yaml |
Switches rendering to validated/normalized helper outputs; ensures PVC/mount logic works with string booleans. |
charts/chromadb-chart/templates/_helpers.tpl |
Adds boolean normalization + persist directory absolute-path validation helpers and uses them in v1 config generation. |
README.md |
Updates examples and value docs to reflect boolean/string-boolean acceptance and path requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chromadb.allowReset,chromadb.isPersistent, andchromadb.persistDirectoryallowReset/isPersistent, normalize rendered values to lowercasechromadb.persistDirectoryas a non-empty absolute pathValidation
bash tests/ci_smoke.shCloses #96