Skip to content

Comments

Validate chart parameters for #96#134

Merged
tazarov merged 1 commit intomainfrom
codex/issue-96-parameter-validation
Feb 20, 2026
Merged

Validate chart parameters for #96#134
tazarov merged 1 commit intomainfrom
codex/issue-96-parameter-validation

Conversation

@tazarov
Copy link
Contributor

@tazarov tazarov commented Feb 20, 2026

Summary

  • add Helm template validation helpers for chromadb.allowReset, chromadb.isPersistent, and chromadb.persistDirectory
  • accept booleans or case-insensitive string booleans for allowReset/isPersistent, normalize rendered values to lowercase
  • enforce chromadb.persistDirectory as a non-empty absolute path
  • wire normalized values through statefulset env/PVC/mount rendering and v1 config generation
  • add regression tests for valid/invalid inputs and update docs/examples

Validation

  • bash tests/ci_smoke.sh

Closes #96

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds strong Helm chart input validation and normalization for key ChromaDB parameters to prevent misconfiguration at install/upgrade time (per #96), and wires the normalized values through rendered manifests and v1 server config generation.

Changes:

  • Introduces Helm helper templates to validate/normalize chromadb.allowReset, chromadb.isPersistent, and chromadb.persistDirectory.
  • Uses normalized values when rendering StatefulSet env vars, PVC creation, and volume mounts.
  • Extends regression tests and updates README examples/docs to reflect accepted inputs and normalization behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/test_v1_config.sh Adds test helpers and regression cases for valid/invalid boolean strings and persist directory path validation.
charts/chromadb-chart/templates/statefulset.yaml Switches rendering to validated/normalized helper outputs; ensures PVC/mount logic works with string booleans.
charts/chromadb-chart/templates/_helpers.tpl Adds boolean normalization + persist directory absolute-path validation helpers and uses them in v1 config generation.
README.md Updates examples and value docs to reflect boolean/string-boolean acceptance and path requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tazarov tazarov merged commit 4f57d01 into main Feb 20, 2026
12 checks passed
@tazarov tazarov deleted the codex/issue-96-parameter-validation branch February 20, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameter validation

1 participant