Format Code

[hsbasu]

• Using custom script to extract version from debian/changelog
• Fix tab spacing in metadata file

[amit9838]

added comments

[hsbasu]

I built both snap and flatpak locally on my system. And tested the app. Both of them are working.

[hsbasu]

I think we should change the snap and flatpak workflow so that it always checks for any build errors on any branch and PR. This way before creating a PR we should be able to fix any build issue.

[amit9838]

I want to know that , lets say i'm building new version(1.0.3) and Im compiling the flatpak or snap , how can i Change the version to 1.0.3, or is it going to pick when it is released

[hsbasu]

It will pick the version automatically. You just need to update these files:

data/io.github.amit9838.mousam.appdata.xml.in
debian/changelog

After you have updated the data/io.github.amit9838.mousam.appdata.xml.in with a new version, I'll update the debian/changelog using the command gbp dch --full -N <the new version in data/io.github.amit9838.mousam.appdata.xml.in> -D stable.

Edit: I think you might also need to use --since option as well with gbp dch. Anyway. If you ping me after updating the data/io.github.amit9838.mousam.appdata.xml.in, I'll do the rest for you.

[hsbasu]

@amit9838 I would suggest using the Squash and merge option rather than using Merge Commits when merging a PR. You should be able to access these options by clicking the down arrow on the right of Merge Commits options.

[amit9838]

It will pick the version automatically. You just need to update these files:

data/io.github.amit9838.mousam.appdata.xml.in
debian/changelog

After you have updated the data/io.github.amit9838.mousam.appdata.xml.in with a new version, I'll update the debian/changelog using the command gbp dch --full -N <the new version in data/io.github.amit9838.mousam.appdata.xml.in> -D stable.

Edit: I think you might also need to use --since option as well with gbp dch. Anyway. If you ping me after updating the data/io.github.amit9838.mousam.appdata.xml.in, I'll do the rest for you.

I tested this thing, but it is not building the app in runner in debug mode, and I think it not fesible to always build the project and generate new package. And i think there is one more issue of dependency of project over the changelog file in the deb dir(it need to run a script first) to make any new release.
So what i would suggest it to either create a new file may be VERSION.txt in deb dir containing version which can be updated manually whenever a new release is made, or get it from meson file using some python script.
Example :

import re

def get_package_version(file_path):
    with open(file_path, 'r') as file:
        content = file.read()
        version_match = re.search(r"version:\s*'([\d.]+)'", content)
        if version_match:
            return version_match.group(1)
        else:
            return None

meson_file_path = 'meson.build'
version = get_package_version(meson_file_path)
if version:
    print(f"The package version is: {version}")
else:
    print("Package version not found in the meson.build file.")

[hsbasu]

Which runner did you use and how?

[amit9838]

I mean Builder
https://flathub.org/apps/org.gnome.Builder

[hsbasu]

And i think there is one more issue of dependency of project over the changelog file in the deb dir(it need to run a script first) to make any new release.

Which script are you saying? Can you explain?

So what i would suggest it to either create a new file may be VERSION.txt in deb dir containing version which can be updated manually whenever a new release is made, or get it from meson file using some python script.

Debian packaging does not work that way. For debian packaging, you create the changelog file first. Before you build a .deb package.

[hsbasu]

I mean Builder https://flathub.org/apps/org.gnome.Builder

Give me some time. Leave the PR as it is. I'll test it with gnome-builder. Have you tried following flatpak packaging tutorials here?

There they say that to build a flatpak you just need to run

flatpak-builder build-dir io.github.amit9838.mousam.json # build step
flatpak-builder --user --install --force-clean build-dir io.github.amit9838.mousam.json # testing step
flatpak run io.github.amit9838.mousam

If these two steps does not show any issue, then everything's alright.

[hsbasu]

I mean Builder https://flathub.org/apps/org.gnome.Builder

@amit9838 Can you paste the error that you are getting on gnome-builder?

In my case its showing this:

The state dir (/home/himadri/Projects/project-mamolinux/Side_projects/my-repos/packages/apps/mousam/.flatpak-builder) is not on the same filesystem as the target dir (/home/himadri/.var/app/org.gnome.Builder/cache/gnome-builder/projects/mousam/flatpak/staging)

because source and target directory are on two different partitions.

[amit9838]

Have you tried building using play button given in the menubar (center)

[amit9838]

And i think there is one more issue of dependency of project over the changelog file in the deb dir(it need to run a script first) to make any new release.

Which script are you saying? Can you explain?

So what i would suggest it to either create a new file may be VERSION.txt in deb dir containing version which can be updated manually whenever a new release is made, or get it from meson file using some python script.

Debian packaging does not work that way. For debian packaging, you create the changelog file first. Before you build a .deb package.

I mean this command,
gbp dch --full -N <the new version in data/io.github.amit9838.mousam.appdata.xml.in> -D stable

So, you can create the changelog file, without modefing the meson.build file right?

[hsbasu]

And i think there is one more issue of dependency of project over the changelog file in the deb dir(it need to run a script first) to make any new release.

Which script are you saying? Can you explain?

So what i would suggest it to either create a new file may be VERSION.txt in deb dir containing version which can be updated manually whenever a new release is made, or get it from meson file using some python script.

Debian packaging does not work that way. For debian packaging, you create the changelog file first. Before you build a .deb package.

I mean this command, gbp dch --full -N <the new version in data/io.github.amit9838.mousam.appdata.xml.in> -D stable

So, you can create the changelog file, without modefing the meson.build file right?

Yes. Of course. I changed it to dynamic version so that the meson.build need not be modified every time we do a version update.

[hsbasu]

Have you tried building using play button given in the menubar (center)

Yes. I clicked on that to build. Actually, gnome-builder is just an IDE like VS Code. It's not necessary to build flatpak or snaps. And IDE, you can use anything, be it gnome-builder or Code or Atom.

[amit9838]

Ok, so deb build entirly depends on changelog file. So lets remove dynamic versioning from. For now we can change it manually on new release. W'll fix it later.

[hsbasu]

Ok, so deb build entirly depends on changelog file. So lets remove dynamic versioning from. For now we can change it manually on new release. W'll fix it later.

Not entirely. But it's part of it. It's more complex than that.

[hsbasu]

I'll remove the versioning part from this PR.

[hsbasu]

@amit9838 I updated this commit and now it only fixes the tab spacing in the metadata file.

[amit9838]

Thnaks, LGTM