-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code and add scrollbar #77
Conversation
hsbasu
commented
Feb 12, 2024
•
edited
Loading
edited
- Load css from css file instead of hard-coding it as python. Provides better readability in IDEs
- Remove eol spaces
- Fix inconsistent tab spacing
- Remove excutable permission from mousam.in, meson makes it excutable during install for all packaging methods
can you also attach .flatpak file |
Flatpak does not generate a file. At least I couldn't find any. You can test using these commands:
|
Can you try this. flatpak-builder build/ io.github.amit9838.mousam.json
flatpak build-export export build
flatpak build-bundle export mousam.flatpak io.github.amit9838.mousam.json Above command will ganarate mousam.flatpak in the current dir (project dir) Alternatively you can generate .flatpak package using gnome-builder. |
This is a better way. I think I'll create a bash script called test for local testing purpose. |
7a23793
to
dedbe80
Compare
@amit9838 Reverted back the call for css styles to main.py. Ready for |
can you attach .flatpak file, may be zip it first before uploading |
Archive.zip |
Sorry I didn't get this. Where do you want me to attach the scroll bar? |
I mean simply adding the scrollbar is not the solution for this problem. We need to check what else we can do here. |
On low res displays the part of the window is going out of display. It is impossible to view the outliers no matter how you move the window towards top or bottom or left or right. This happens because the cards are not rearranging and/or resizing itself. One temporary fix to view the unviewable parts is to add a scroll bar. For which even though only part of the app is visible, at least by scrolling other unviewable parts will be visible. Edit: GTK is not known to be a resolution friendly ui framework. For the app to work on any display resolution you might consider flutter. Or rearrange and /or resize the cards and their widths so that full portion of the app is visible in the width direction. |
Ya, Gtk sucks, but now it has improved a lot. So if we are going to build some complex ui, it can be hard to cover all the aspects. So i think it better to foucs on the core part first. |
Okay. I'll remove the scroll bar part as well. |
dedbe80
to
4f14993
Compare
@amit9838 Removed the scroll bar. |
- Load css from css file instead of hard-coding it as python. Provides better readability in IDEs - Remove eol spaces - Fix inconsistent tab spacing - Remove excutable permission from mousam.in, meson makes it excutable during install for all packaging methods
4f14993
to
3a82450
Compare