feat: Added the primary button feature#86
Open
denshaw-09 wants to merge 4 commits intoamitkumardemo:mainfrom
Open
feat: Added the primary button feature#86denshaw-09 wants to merge 4 commits intoamitkumardemo:mainfrom
denshaw-09 wants to merge 4 commits intoamitkumardemo:mainfrom
Conversation
|
@denshaw-09 is attempting to deploy a commit to the amitkumardemo's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a centralized PrimaryButton component to improve the consistency of primary action buttons, while also adding theme detection code to the onboarding form.
- Added PrimaryButton.jsx with unified styling and behavior for primary buttons.
- Modified onboarding form to include theme detection using matchMedia.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/ui/PrimaryButton.jsx | New reusable button component consolidating style and onClick logic for primary buttons. |
| app/(main)/onboarding/_components/onboarding-form.jsx | Added a state and effect to detect the user's dark mode preference. |
it's for adding a variation so i think we should remove it for now as it won't make much of the changes and we can add more features later for the buttons if required Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Author
|
why are the checks failing? |
Owner
|
attach a video or photo of your work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this issue resolved the problem for the primary button functionality across the different components and i tested the functionality across different devices as well
here is the summary:
What Changed?
Consistency: All primary action buttons now use the same styles and logic.
Maintainability: If you want to change the color, padding, or add a loading spinner, you only need to update PrimaryButton.jsx.
Cleaner Code: You no longer have to repeat button styles or logic in multiple places.
Please review the changes once and let me know for any changes.
closes issue #3