Get EM back #888
Draft
Get EM back #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has the main infrastructures to include Aparallel effects by solving apardot and stepping Aparallel accordingly. Of course many bugs must reside and for now the EM effects are not included in the GK rhs. I checked that the 2x2v D3D regression test is behaving exactly the same if we activate EM or not. I want to see next if we get meaningful Apar and Apardot values as the diagnostics are included.
…ot in species. Mu0 needs to be set in the input file, other wise there will be a division by 0.
… the species struct.
…to get_em_back
…ing and recreating a solver because just rebuilding the matrix introduces memory leaks.
… em computation in comp time, note a "TODO" for the next step, lso removed an unused variable in fem_poisson_perp
We cannot use GKYL_GK_COLLISIONLESS_EM because this will remove the kernels for surf and volume terms... I want EM to keep them and just call new ones that will only add the EM contributions, especially because I need the ES RHS to compute current dot. We'll have to think about how to do that in a good way
…w if we are evolving ES, EM_BPAR, EM_BPERP, or EM without mentioning NO_BY anymore. Instead a new boolean `no_by` is introduced in the collisionless public and private tables. The kernel selections is now done according to the value of no_by and not according to the collisionless_id anymore. This makes the code cleaner and avoid introducing three other enums for EM+NO_BY.
…cies struct, I don't think we will add FLR to EM soon). We also add an option to the gkyl_dg_gyrokinetic updater to get an EM adder only or ES. And also add many empty kernels for the code to compile and checking the workflow. This branch is related to the gkylcas branch ammarhakim/gkylcas#89
…tuff, then all the EM.
…code is able to run without apparent issue with EM option turned on. need to check how clean it is in valgrind.
…efactored in main...)
…in' into get_em_back
…x2v and 2x2v em testcases are leak clean on CPU. will test GPU and MPI more thoroughly on Perlmutter.
…r the refactor. (KAW test is still correct.)
My collection is increasing: 🐛🪲🪳
…ionless flux surf computation 🤪
…at we should pass apardot instead of apar when adding appardot only
…cation (allows to remove the last (?) if statement in the field rhs computation)
… flag passed to the collisionless table. It's better like this because otherwise we would need a colliisonless type for ES and each EM scenarii.
…o reflect that they are disabled if we are in the electrostatic case.
…ated array with empty functions in the RK stepper so we allocate and release them to be sure.
… stays smooth. We also smooth apar after the IC ampere solve.
…case. Will reintroduce it later in a better manner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the DR #867 and gkylcas#89
... details soon ...