-
Notifications
You must be signed in to change notification settings - Fork 9
Orbit average phase for tandem mirrors #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Maxwell-Rosen
wants to merge
16
commits into
main
Choose a base branch
from
gk-oap-tandem-mirror-symmetric-z0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of B instead of the min/max operation. This lets us find the value of B at the wall as well
…he grid the position map operates on for the optimize function is always 3x but during the mask it's only 1x because of deflation
… functionality so that it gets the wall too. Pass the wall coordinate and Bmag into some updaters. It's valgrind clean on my laptop, which is why I'm making the commit here. Things should be passed into the right places and it's a good checkpoint. Changes are made to the cuda scripts, but they are not tested with gpu-sanitizeer
…rror throat. It's general for species of all charges. Valgrind clean. Update GPU kernels to compute this as well.
…lation. For some reason, the time step for the simulation in the OAP is still tiny. Must debug, but the cfl rate diagnostics look very reasonable and as we would expect
…at we actually should multiply it. Testing will show if this is a good ida. I think it makes sense because of the v_th in the omegaH formula.
…ted! The multi-species POA scheme works!
…ding a regression test for looking at tandem mirrors. When the code is run in single mirror cell configurations, the tandem components are there to duplicate the outer cell. This implementation assumes symmetry in the magnetic field around z=0, which is a good assumption for the input files we are working with.
…d remove unnecessary variable declarations
… symmetry check and modify mu_bound calculation in loss_cone_mask_gyrokinetic_advance for correct boundary handling. Tandem mirror testing is working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgkyl gk_mirror_boltz_elc_poa_1x2v_p1-ion_fdot_multiplier_0.gkyl sel --z2 0.5 pl