Change periodicity handling in init_maxwellian_gaussian function #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epend only on the species, not on the field
manauref
requested changes
Jan 8, 2026
Collaborator
manauref
left a comment
manauref
left a comment
There was a problem hiding this comment.
@Antoinehoff shouldn't this also check the is_dir_periodic of the app? i.e., if we are doing a periodic sim without IWL, then this code here should also set fg_ctx.is_dir_periodic = true, right?
Antoinehoff
commented
Jan 9, 2026
manauref
approved these changes
Jan 9, 2026
tnbernard
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #929
The setup of the periodicity for the Maxwellian-Gaussian Projection does not call information about the field anymore. It now depends only on the species.
The code is a bit more complicated though because one cannot directly call the BC from the
species->infostructure for a prescribed dimension but one has to pass by thegk_fetch_bc_with_dir_edgeroutine.Also, I am thinking now that it could be useful to have an assert checking that if we set
GKYL_BC_GK_SPECIES_IWLto one edge, the other edge is alsoGKYL_BC_GK_SPECIES_IWL.