Test against PHP 8.4 #378
Test against PHP 8.4 #378
Conversation
Nek-
force-pushed
the
php8-4-on-ci
branch
2 times, most recently
from
5d8b88a to
de8cda6
Compare
Fix psalm config PSAML has problems with goto analyze. It leads to wrong issues: vimeo/psalm#11327
| @@ -48,8 +48,8 @@ | |||
| "phpunit/phpunit": "^9", | |||
| "amphp/http-server": "^3", | |||
| "kelunik/link-header-rfc5988": "^1", | |||
| "psalm/phar": "~5.23", | |||
| "laminas/laminas-diactoros": "^2.3" | |||
| "psalm/phar": "*", | |||
There was a problem hiding this comment.
The version will be 6 but different regarding the PHP version.
There was a problem hiding this comment.
You should at least require the latest ^6.8.5
There was a problem hiding this comment.
Did you read the message I wrote just above?
There was a problem hiding this comment.
Yes, and your assumption is wrong: you should always require the latest available version of Psalm.
There was a problem hiding this comment.
The composer.json of psalm/phar does not allow this.
There was a problem hiding this comment.
It does, just require psalm 6.8.5
| @@ -4,9 +4,12 @@ | |||
| phpVersion="8.1" | |||
| resolveFromConfigFile="true" | |||
| rememberPropertyAssignmentsAfterCall="false" | |||
| ensureOverrideAttribute="false" | |||
There was a problem hiding this comment.
Please set this to true, override attributes are recommended adn compatible with all PHP versions if the symfony/polyfill-php83 packages required
| @@ -4,9 +4,12 @@ | |||
| phpVersion="8.1" | |||
| resolveFromConfigFile="true" | |||
| rememberPropertyAssignmentsAfterCall="false" | |||
| ensureOverrideAttribute="false" | |||
| findUnusedCode="false" | |||
There was a problem hiding this comment.
It's a library, everything is unused code!
There was a problem hiding this comment.
No, public code must be marked with @api, the remaining code is private, unused code.
There was a problem hiding this comment.
There was a problem hiding this comment.
Please keep this config off unless psalm offers a way to "default-mark" everything non-internal & non-private as API.
There was a problem hiding this comment.
The problem with default-marking everything non-internal and non-private as API is with non-library codebases (that have no public surface apart from API controllers and other entry points).
Some not so clean library codebases have the same problem as well, where internal details are needlessly exposed as public and not marked as internal.
Explicitly marking public API with @api solves both issues.
There was a problem hiding this comment.
@danog I think it would be a good thing to make that configurable in psalm. libraryAssumeApi="true" or such.
| @@ -59,5 +70,11 @@ | |||
| <directory name="src" /> | |||
| </errorLevel> | |||
| </RiskyTruthyFalsyComparison> | |||
|
|
|||
| <InvalidReturnType> | |||
There was a problem hiding this comment.
Don't suppress this at the file level
| </errorLevel> | ||
| </ImplicitToStringCast> | ||
|
|
||
| <InvalidOperand> |
There was a problem hiding this comment.
Don't suppress this at a project level
There was a problem hiding this comment.
vimeo/psalm#11329 will fix what you're (incorrectly) trying to fix
There was a problem hiding this comment.
It's not only that. The code often do some float * int, which is perfectly fine, btw string . float is also ok.
There was a problem hiding this comment.
If you have issues with that, just set strictBinaryOperands="false", do not suppress the issue as it also covers valid errors
There was a problem hiding this comment.
We need lower versions of psalm for php versions compatibility. It would not work anyway.
There was a problem hiding this comment.
Psalm is capable of running scans for versions down to php 5.4 on php 8.4, just pass the correct PHP version using the --php-version parameter.
There was a problem hiding this comment.
Psalm scans should always run on PHP 8.4.4 or above to avoid platform bugs, to target lower versions of PHP simply use the --php-version parameter.
I already use the http client with PHP 8.4. But I figured out that the devkit was limited to PHP 8.3. Let's update things!
Outch. It has been a battle to update psalm configuration. I added some new rules to avoid many many MANY useless casts.