Skip to content

[2.x] Fix implicitly nullable parameter for PHP 8.4 compatibility #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[2.x] Fix implicitly nullable parameter for PHP 8.4 compatibility #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5621b14
Fix implicitly nullable parameter
GromNaN Sep 18, 2024
a2dcc6f
Run tests on newest PHP versions
GromNaN Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ jobs:
- operating-system: 'ubuntu-latest'
php-version: '8.1'

- operating-system: 'ubuntu-latest'
php-version: '8.2'

- operating-system: 'ubuntu-latest'
php-version: '8.3'

- operating-system: 'ubuntu-latest'
php-version: '8.4'

- operating-system: 'windows-latest'
php-version: '8.1'
job-description: 'on Windows'
Expand Down
2 changes: 1 addition & 1 deletion src/AsyncTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ final protected function setTimeout(int $timeout)
*
* @return callable|MockObject Mock object having only an __invoke method.
*/
final protected function createCallback(int $invocationCount, callable $returnCallback = null): callable
final protected function createCallback(int $invocationCount, ?callable $returnCallback = null): callable
{
$mock = $this->createMock(CallbackStub::class);
$invocationMocker = $mock->expects($this->exactly($invocationCount))
Expand Down
Loading