Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing daisy feature ordering to match SIFT. Closes #186. #205

Merged
merged 2 commits into from
Jan 20, 2016

Conversation

etrain
Copy link
Contributor

@etrain etrain commented Jan 20, 2016

This fix transposes the order of features coming out of the Daisy Extractor so that it's a drop in replacement for the SIFT featurizer -- logically these things do different things but at least "Image Descriptors" should have a common structure. Closes #186

@shivaram
Copy link
Contributor

LGTM

@shivaram
Copy link
Contributor

Would be good to have a test comparing them somehow ? i.e. enforcing they are the same in Daisy and SIFT ?

@etrain
Copy link
Contributor Author

etrain commented Jan 20, 2016

I can do that, but now I'm wondering if an ImageDescriptor class is a better data structure to be using here, rather than enforcing object structure by convention. The downside to this is that either downstream operators (e.g. PCA, GMM, FV) would need to be changed to handle this new class (probably too big for this PR) or a conversion node would have to be invented that extracts out the matrix in the right order, which feels like a hack.

I'm going to add a test for this, and I've opened #210 to address the ImageDescriptor problem in a future PR.

@etrain
Copy link
Contributor Author

etrain commented Jan 20, 2016

Test case added.

@shivaram
Copy link
Contributor

LGTM

shivaram added a commit that referenced this pull request Jan 20, 2016
Fixing daisy feature ordering to match SIFT. Closes #186.
@shivaram shivaram merged commit 74e0f6a into amplab:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daisy Extractor Fix
2 participants