Skip to content

chore: enable compatibility with Serverless Framework v4 #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

czubocha
Copy link
Contributor

Fixes #632

Description of Issue Fixed
Users can't use serverless-domain-manager with Serveerless Framework v4.

Changes proposed in this pull request:

Add ^4.0.0 to peerDependencies

@czubocha
Copy link
Contributor Author

Hi, @rddimon! Could you take a look at this PR and the proposed changes to peerDependencies, please?

@czubocha czubocha changed the title chore: enable compatibility for Serverless Framework v4 chore: enable compatibility with Serverless Framework v4 Jul 1, 2024
Copy link

@jcoaks jcoaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the dependency restriction to add v4

@czubocha
Copy link
Contributor Author

Hi @rddimon and @jcoaks, since this change has been approved, could you please merge this PR and release a new plugin version?

@rddimon rddimon merged commit fa193e3 into amplify-education:main Jul 18, 2024
5 of 6 checks passed
@cbschuld
Copy link

cbschuld commented Aug 7, 2024

Hey @rddimon & @jcoaks any chance there is an updated release coming soon that will push out support for v4? I see the updates in main but the latest release is obviously from back in March. Thanks for help/work/tooling!

@aareyes96
Copy link

Hello. I have same issue. Is possible to use the plugin ??? I'm using "serverless": "^4.1.21"

npm ERR! Could not resolve dependency: npm ERR! peer serverless@"^2.60 || ^3.0.0" from serverless-domain-manager@7.3.8 npm ERR! node_modules/serverless-domain-manager npm ERR! serverless-domain-manager@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@ashley-jisc
Copy link

Hi @rddimon & @jcoaks This error still shows for the latest version of serverless ~4.1.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does serverless domain manager work with serverless framework 4?
6 participants