Skip to content

chore: use lockfiles for NPM dependencies#117

Merged
daniel-graham-amplitude merged 1 commit intomainfrom
codex/release-lockfiles
Mar 12, 2026
Merged

chore: use lockfiles for NPM dependencies#117
daniel-graham-amplitude merged 1 commit intomainfrom
codex/release-lockfiles

Conversation

@daniel-graham-amplitude
Copy link
Copy Markdown
Contributor

Applies the equivalent of amplitude/Amplitude-Swift#350 in this repository.

Changes

  • switch release workflow from inline npx -p ... installs to lockfile-based commands
  • run npm ci before semantic-release in dry-run and release steps
  • run semantic-release via npm exec
  • add root package.json + package-lock.json for deterministic dependency resolution
  • ignore node_modules/ in .gitignore where needed

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces lockfile-based Node tooling to make the repository’s semantic-release execution in GitHub Actions deterministic, replacing ad-hoc npx -p ... installs.

Changes:

  • Adds a root package.json to declare the semantic-release toolchain and supporting plugins.
  • Updates the release workflow to run npm ci and execute semantic-release via npm exec.
  • Ignores node_modules/ in .gitignore.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Introduces Node dependencies intended for the release workflow tooling.
.gitignore Adds node_modules/ to avoid committing installed artifacts.
.github/workflows/release.yml Switches semantic-release invocation to lockfile-based install (npm ci) + npm exec.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daniel-graham-amplitude daniel-graham-amplitude merged commit 6e08008 into main Mar 12, 2026
9 checks passed
@daniel-graham-amplitude daniel-graham-amplitude deleted the codex/release-lockfiles branch March 12, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants