Update to comments

amplitude · Dec 1, 2023 · 4504054 · 4504054
1 parent 8f2aed2
commit 4504054
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/experiment-browser/src/config.ts b/packages/experiment-browser/src/config.ts
@@ -150,7 +150,7 @@ export interface ExperimentConfig {
  | **instanceName** | `$default_instance` |
  | **fallbackVariant**         | `null`                 |
  | **initialVariants**         | `null`                 |
- | **initialFlags**         | `null`                 |
+ | **initialFlags**         | `undefined`                 |
  | **source** | `Source.LocalStorage` |
  | **serverUrl**    | `"https://api.lab.amplitude.com"` |
  | **flagsServerUrl**    | `"https://flag.lab.amplitude.com"` |
@@ -173,7 +173,7 @@ export const Defaults: ExperimentConfig = {
   instanceName: '$default_instance',
   fallbackVariant: {},
   initialVariants: {},
-  initialFlags: null,
+  initialFlags: undefined,
   source: Source.LocalStorage,
   serverUrl: 'https://api.lab.amplitude.com',
   flagsServerUrl: 'https://flag.lab.amplitude.com',

diff --git a/packages/experiment-browser/src/experimentClient.ts b/packages/experiment-browser/src/experimentClient.ts
@@ -396,9 +396,9 @@ export class ExperimentClient implements Client {
   private mergeInitialFlagsWithStorage(): void {
     if (this.config.initialFlags) {
       const initialFlags = JSON.parse(this.config.initialFlags);
-      for (const key in initialFlags) {
-        if (!this.flags.get(initialFlags[key].key)) {
-          this.flags.put(initialFlags[key].key, initialFlags[key]);
+      for (const flag of initialFlags) {
+        if (!this.flags.get(flag.key)) {
+          this.flags.put(flag.key, flag);
         }
       }
     }