feat: increase flag polling interval; add flag poller interval config #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhukaihan
approved these changes
Nov 25, 2024
Comment on lines
118
to
122
| config.flagConfigPollingIntervalMillis < minFlagPollerIntervalMillis | ||
| ? minFlagPollerIntervalMillis | ||
| : config.flagConfigPollingIntervalMillis | ||
| ? config.flagConfigPollingIntervalMillis | ||
| : Defaults.flagConfigPollingIntervalMillis, |
There was a problem hiding this comment.
Maybe add parenthesis?
Also A ? A : B == A ?? B if we're just testing for null or undefined.
tyiuhc
reviewed
Nov 25, 2024
Comment on lines
116
to
122
| // Force minimum flag config polling interval. | ||
| flagConfigPollingIntervalMillis: | ||
| config.flagConfigPollingIntervalMillis < minFlagPollerIntervalMillis | ||
| ? minFlagPollerIntervalMillis | ||
| : config.flagConfigPollingIntervalMillis | ||
| ? config.flagConfigPollingIntervalMillis | ||
| : Defaults.flagConfigPollingIntervalMillis, |
There was a problem hiding this comment.
simplify for legibility:
flagConfigPollingIntervalMillis = config.flagConfigPollingIntervalMillis
? Math.max(config.flagConfigPollingIntervalMillis, minFlagPollerIntervalMillis)
: Defaults.flagConfigPollingIntervalMillis;
tyiuhc
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist