Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't convert number value 0 to undefined on evaluating conditions #143

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: don't convert number value 0 to undefined on evaluating conditions #143

merged 1 commit into from
Dec 2, 2024

Conversation

tkainrad
Copy link
Contributor

@tkainrad tkainrad commented Dec 2, 2024 •
edited
Loading

Summary

Fixes a small bug when comparing against the number 0.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@tkainrad tkainrad requested a review from bgiori December 2, 2024 17:06
@tkainrad tkainrad changed the title Fix evaluation against the number value 0 fix: don't convert number value 0 to undefined on evaluating conditions Dec 2, 2024
@bgiori bgiori merged commit 2826ef2 into main Dec 2, 2024
7 of 8 checks passed
@bgiori bgiori deleted the fix-evaluation-against-number-0-value branch December 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkainrad @bgiori