Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Catch error in getUrlParam() in DefaultUserProvider #150

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: Catch error in getUrlParam() in DefaultUserProvider #150

merged 1 commit into from
Dec 23, 2024

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Dec 23, 2024

Summary

Catch error from getUrlParam() in DefaultUserProvider when new URL(this.globalScope.location.href) throws an error.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@tyiuhc tyiuhc merged commit 007ff68 into main Dec 23, 2024
6 checks passed
@tyiuhc tyiuhc deleted the catch-geturlparam-error branch December 23, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori bgiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyiuhc @bgiori