feat: WebExperiment class #152
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evice id, make doFlags private
bgiori
requested changes
Jan 6, 2025
| return; | ||
|
|
||
| /** | ||
| * Set the previous URL for tracking back/forward navigation. Set previous URL to prevent infinite redirection loop |
There was a problem hiding this comment.
Is there a way we can prevent this for them?
| * Get redirect URLs for flags. | ||
| * @param flagKeys | ||
| */ | ||
| public getRedirectUrls( |
There was a problem hiding this comment.
What's the use case for this function?
There was a problem hiding this comment.
This is for the case where the developer want to implement their own redirect handler.
| * @param key | ||
| * @param variant | ||
| */ | ||
| public previewVariant(key: string, variant: string) { |
There was a problem hiding this comment.
Support previewing multiple flags/variants. Maybe we just merge this with applyVariants with another config like preview?
| * Set URL change listener to revert mutations and apply variants on back/forward navigation. | ||
| * @param flagKeys | ||
| */ | ||
| public setUrlChangeListener(flagKeys: string[]) { |
There was a problem hiding this comment.
Is this supposed to have a listener argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist