Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make storage synchronous #90

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: make storage synchronous #90

merged 2 commits into from
Nov 3, 2023

Conversation

bgiori
Copy link
Collaborator

@bgiori bgiori commented Nov 2, 2023

Summary

Storage functions were needlessly async

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bgiori bgiori requested a review from tyiuhc November 2, 2023 23:22
@bgiori bgiori changed the title make storage synchronous fix: make storage synchronous Nov 2, 2023
@bgiori bgiori merged commit f279830 into main Nov 3, 2023
6 checks passed
@bgiori bgiori deleted the un-async-storage branch November 3, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyiuhc tyiuhc tyiuhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgiori @tyiuhc